close restart session right away#7153
Merged
IanMatthewHuff merged 2 commits intomicrosoft:masterfrom Aug 30, 2019
Merged
Conversation
IanMatthewHuff
commented
Aug 29, 2019
| if (oldStatusHandler) { | ||
| oldSession.statusChanged.disconnect(oldStatusHandler); | ||
| } | ||
| // Don't shutdown old sessions yet. This seems to hang tests. |
Member
Author
There was a problem hiding this comment.
This makes me worry a bit, but I tried the tests locally with both mock and real jupyter and they all passed.
Member
Author
There was a problem hiding this comment.
They might have issues on AzDO (I've seen that at times) but this code looks clearly wrong and we can always investigate a failing test later.
Codecov Report
@@ Coverage Diff @@
## master #7153 +/- ##
==========================================
- Coverage 58.5% 58.43% -0.07%
==========================================
Files 485 485
Lines 21446 21446
Branches 3462 3462
==========================================
- Hits 12546 12533 -13
- Misses 8122 8137 +15
+ Partials 778 776 -2
Continue to review full report at Codecov.
|
DavidKutu
approved these changes
Aug 30, 2019
IanMatthewHuff
added a commit
to IanMatthewHuff/vscode-python
that referenced
this pull request
Aug 30, 2019
* close restart session right away * ignore errors on await, don't want to stop and wait for shutdown
10 tasks
IanMatthewHuff
added a commit
that referenced
this pull request
Aug 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #6975
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)