Skip to content

Conversation

@kimadeline
Copy link

🍒 -pick release changes to master:

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

kimadeline and others added 3 commits July 9, 2019 16:30
* Simplify & fix crypto.createHash
* Add tests
* Fix python test in news folder (microsoft#6398)
* Fix broken python tests in news
* Revert changes
* Enable experiment for always displaying the test explorer (microsoft#6330)

* Add logging
@kimadeline kimadeline added the no-changelog No news entry required label Jul 9, 2019
@kimadeline kimadeline requested a review from karrtikr July 9, 2019 23:33
@kimadeline kimadeline merged commit a4c6eed into microsoft:master Jul 10, 2019
@kimadeline kimadeline deleted the cherry-pick-release branch July 10, 2019 00:00
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants