Skip to content

Fixes to activation of Conda environments#5934

Merged
DonJayamanne merged 1 commit intomicrosoft:masterfrom
DonJayamanne:fixActivation
Jun 6, 2019
Merged

Fixes to activation of Conda environments#5934
DonJayamanne merged 1 commit intomicrosoft:masterfrom
DonJayamanne:fixActivation

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jun 6, 2019

For #5929

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

ericsnowcurrently
ericsnowcurrently approved these changes Jun 6, 2019
View reviewed changes
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DonJayamanne DonJayamanne merged commit ee1c25d into microsoft:master Jun 6, 2019
DonJayamanne added a commit that referenced this pull request Jun 6, 2019
@DonJayamanne
Fixes to activation of Conda environments (#5934)
53ef270
DonJayamanne added a commit that referenced this pull request Jun 6, 2019
@DonJayamanne
Point release with fixes for debugger and activation of environments (#…
5db26f8 
…5939)

* Fixes to activation of Conda environments (#5934)

* Disable quoting paths sent to the debugger as args (#5936)

* Disable quoting paths sent to the debugger as args

* Remove unnecessary class

* Fix typo

* Fixes to tests

* Update version for new point release
@DonJayamanne DonJayamanne deleted the fixActivation branch June 6, 2019 22:23
@syagev
Copy link

syagev commented Jun 7, 2019

@DonJamanne not that I completely understand what's going on (and I really appreciate the quick turnaround on dealing with this issue!) but just wanted to point out that in #5929 users experiencing the error don't necessarily have a conda environment (I'm using pipenv).

I just saw the PR's title and thought maybe there's some confusion.

Thanks!

@DonJayamanne
Copy link
Author

DonJayamanne commented Jun 7, 2019

@syagev
Thanks for pointing that out, we came across this in conda environments.
Will change the label accordingly. Thanks.
Nevertheless, I believe the issue has been resolved at your end.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DonJayamanne @syagev @ericsnowcurrently