Ensure using request: launch item in launch.json for debugging sends pathmappings#5552
Merged
DonJayamanne merged 5 commits intomicrosoft:masterfrom May 21, 2019
Merged
Conversation
added 2 commits
May 3, 2019 17:15
DonJayamanne
requested changes
May 20, 2019
DonJayamanne
left a comment
DonJayamanne
left a comment
There was a problem hiding this comment.
I don't see any changes to package.json that would enable pathMapptings in launch.json for launch types.
I.e. from a users perspective this is still broken.
Also, in light of Remote Extensions I'm not sure we need this, will need to discuss with team.
DonJayamanne
requested changes
May 20, 2019
DonJayamanne
left a comment
DonJayamanne
left a comment
There was a problem hiding this comment.
Please add the following change for launch configuration:
- If
debugConfiguration.pathMappingsis empty, then always add the following as a default value:
{
"localRoot": "${workspaceFolder}",
"remoteRoot": "."
}
karrtikr
force-pushed
the
pathmappings
branch
2 times, most recently
from
995d1de to
e73ac3e
Compare
DonJayamanne
approved these changes
May 21, 2019
DonJayamanne
added a commit
that referenced
this pull request
May 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3568
[ ] Appropriate comments and documentation strings in the code[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.