Skip to content

Conversation

@IanMatthewHuff
Copy link
Member

For #5420

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff requested a review from rchiodo April 23, 2019 00:20
@IanMatthewHuff IanMatthewHuff merged commit 3febb03 into microsoft:master Apr 23, 2019
IanMatthewHuff added a commit that referenced this pull request Apr 23, 2019
IanMatthewHuff added a commit that referenced this pull request Apr 23, 2019
DonJayamanne added a commit that referenced this pull request Apr 25, 2019
* release: (25 commits)
  Bump version
  remove unexpected trailing commas in JSON files (#5443)
  Fixes to creation of json for Language Server (#5436)
  Update version of Language Server
  Update version (#5435)
  Deprecate travis (#5434)
  Upload vsix to artifacts (#5412)
  Fix the flask app name prompt for launch config. (#5409)
  Reliably end test tasks in Azure Pipelines (#5410)
  fix len error (#5421)
  Fix null cases (#5419)
  Fix sorting of number only lists (#5416)
  add news
  cleanup and functional test
  working first draft
  Fix current cell colors again (#5403)
  Fix data viewer issues (#5405)
  Update 'news' command to directly update the changelog
  Fixes to the test explorer in displaying root (#5383)
  Include pylintrc (#5369)
  ...
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/noneInVarExp branch July 25, 2019 23:50
@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants