Fix null case #5419
Merged
Fix null case #5419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
force-pushed
the
rchiodo/fix_sorting
branch
from
61f4d55 to
be354c4
Compare
| (a: any, b: any): number => { | ||
| const aVal = a[sortColumn].toString(); | ||
| const bVal = b[sortColumn].toString(); | ||
| const aVal = a[sortColumn] ? a[sortColumn].toString() : ''; |
Member
There was a problem hiding this comment.
Possible falsy if there is a 0 in a mixed column of strings and ints. #WontFix
Author
There was a problem hiding this comment.
rchiodo
added a commit
that referenced
this pull request
Apr 23, 2019
DonJayamanne
added a commit
that referenced
this pull request
Apr 25, 2019
* release: (25 commits) Bump version remove unexpected trailing commas in JSON files (#5443) Fixes to creation of json for Language Server (#5436) Update version of Language Server Update version (#5435) Deprecate travis (#5434) Upload vsix to artifacts (#5412) Fix the flask app name prompt for launch config. (#5409) Reliably end test tasks in Azure Pipelines (#5410) fix len error (#5421) Fix null cases (#5419) Fix sorting of number only lists (#5416) add news cleanup and functional test working first draft Fix current cell colors again (#5403) Fix data viewer issues (#5405) Update 'news' command to directly update the changelog Fixes to the test explorer in displaying root (#5383) Include pylintrc (#5369) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5414
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)