Skip to content

Fix the flask app name prompt for launch config. #5409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 1 commit into from
Apr 23, 2019
Merged

Fix the flask app name prompt for launch config. #5409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
"debug.debugFlaskConfigurationLabel": "Flask",
"debug.debugFlaskConfigurationDescription": "Launch and debug a Flask web application",
"debug.flaskEnterAppPathOrNamePathTitle": "Debug Flask",
"debug.flaskEnterAppPathOrNamePathPrompt": "Enter path to application, e.g. 'app.py' or 'app'",
"debug.flaskEnterAppPathOrNamePathPrompt": "Enter the path to the application, e.g. 'app.py' or 'app'",
"debug.flaskEnterAppPathOrNamePathInvalidNameError": "Enter a valid name",
"debug.debugPyramidConfigurationLabel": "Pyramid",
"debug.debugPyramidConfigurationDescription": "Web Application",
Expand Down
1 change: 1 addition & 0 deletions src/client/common/utils/localize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ export namespace DebugConfigStrings {
};
export const enterAppPathOrNamePath = {
title: localize('debug.flaskEnterAppPathOrNamePathTitle'),
prompt: localize('debug.flaskEnterAppPathOrNamePathPrompt'),
invalid: localize('debug.flaskEnterAppPathOrNamePathInvalidNameError')
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/client/debugger/extension/configuration/providers/flaskLaunch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export class FlaskLaunchDebugConfigurationProvider implements IDebugConfiguratio
const selectedApp = await input.showInputBox({
title: DebugConfigStrings.flask.enterAppPathOrNamePath.title(),
value: 'app.py',
prompt: DebugConfigStrings.flask.selectConfiguration.description(),
prompt: DebugConfigStrings.flask.enterAppPathOrNamePath.prompt(),
validate: value => Promise.resolve((value && value.trim().length > 0) ? undefined : DebugConfigStrings.flask.enterAppPathOrNamePath.invalid())
});
if (selectedApp) {
Expand Down