Skip to content

Fix HOME folder substitution when is not in the beginning of path - #19326

Merged
Kartik Raj (karrtikr) merged 1 commit into
microsoft:mainfrom
cpinamtz:bugfix/18532
Aug 2, 2022
Merged

Fix HOME folder substitution when is not in the beginning of path#19326
Kartik Raj (karrtikr) merged 1 commit into
microsoft:mainfrom
cpinamtz:bugfix/18532

Conversation

@cpinamtz

@cpinamtz Carlos Piña Martinez (cpinamtz) commented Jun 18, 2022

Copy link
Copy Markdown

Closes #18532

@ghost

Deleted user (ghost) commented Jun 18, 2022

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@cpinamtz

Carlos Piña Martinez (cpinamtz) commented Jun 20, 2022

Copy link
Copy Markdown
Author

Do I need to re-create the PR but with a branch named just bug? First time contributing here

@karrtikr Kartik Raj (karrtikr) added the bug Issue identified by VS Code Team member as probable bug label Jun 20, 2022
@karrtikr

Copy link
Copy Markdown

Thanks for the PR, I plan to have a look soon. We just needed to add the label bug.

@karrtikr
Kartik Raj (karrtikr) self-requested a review June 21, 2022 18:03

@karrtikr Kartik Raj (karrtikr) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Appreciate the comprehensive work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replacing home dir with ~ sometimes leads to invalid path

2 participants