Repository navigation
Reduce dependency on IOutputChannel - #18114
Merged
Karthik Nadig (karthiknadig) merged 9 commits intoDec 8, 2021
Merged
Conversation
Karthik Nadig (karthiknadig)
force-pushed
the
logging-2
branch
2 times, most recently
from
December 6, 2021 23:42
a50f0d8 to
c9951e0
Compare
Karthik Nadig (karthiknadig)
marked this pull request as ready for review
December 7, 2021 03:43
Karthik Nadig (karthiknadig)
requested a review
from Kim-Adeline Miguel (kimadeline)
December 7, 2021 07:34
Kim-Adeline Miguel (kimadeline)
approved these changes
Dec 8, 2021
Karthik Nadig (karthiknadig)
force-pushed
the
logging-2
branch
from
December 8, 2021 20:39
8adf971 to
84e688b
Compare
|
|
||
| info.forEach((line) => { | ||
| traceInfo(line); | ||
| this.outputChannel.appendLine(line); |
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
* Remove output channel * Remove more logging * fix missed logging * Remove dependency on OutputChannel * Fix tests * add news item * Fix tests * Address comments * Simplify tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18132