Skip to content

Reduce dependency on IOutputChannel - #18114

Merged
Karthik Nadig (karthiknadig) merged 9 commits into
microsoft:mainfrom
karthiknadig:logging-2
Dec 8, 2021
Merged

Karthik Nadig (karthiknadig) merged 9 commits into
microsoft:mainfrom
karthiknadig:logging-2

Conversation

@karthiknadig

@karthiknadig Karthik Nadig (karthiknadig) commented Dec 3, 2021 •

Copy link
Copy Markdown
Member

Closes #18132

@karthiknadig
Karthik Nadig (karthiknadig) force-pushed the logging-2 branch 2 times, most recently from a50f0d8 to c9951e0 Compare December 6, 2021 23:42
@karthiknadig Karthik Nadig (karthiknadig) changed the title Remove dependency on OutputChannel Reduce dependency on IOutputChannel Dec 6, 2021
@karthiknadig
Karthik Nadig (karthiknadig) marked this pull request as ready for review December 7, 2021 03:43
@karthiknadig
Karthik Nadig (karthiknadig) merged commit 8a4f92d into microsoft:main Dec 8, 2021

@karrtikr Kartik Raj (karrtikr) left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commands run by extension are currently not being printed


info.forEach((line) => {
traceInfo(line);
this.outputChannel.appendLine(line);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be removed.

Wes McKinney (wesm) pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
* Remove output channel

* Remove more logging

* fix missed logging

* Remove dependency on OutputChannel

* Fix tests

* add news item

* Fix tests

* Address comments

* Simplify tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove passing IOutputChannel to classes for printing logs

3 participants