Replace deprecated vscode-test with @vscode/test-electron - #16714
Merged
Kartik Raj (karrtikr) merged 5 commits intoJul 23, 2021
Conversation
github-actions
Bot
requested review from
Kartik Raj (karrtikr) and
Karthik Nadig (karthiknadig)
July 18, 2021 13:33
Karthik Nadig (karthiknadig)
requested a review
from Kim-Adeline Miguel (kimadeline)
July 21, 2021 21:36
|
Thank you for your contribution Lei Chen (@iChenLei)! Please create an issue for this PR and mark it as an enhancement, and add a news entry as well. |
Kim-Adeline Miguel (kimadeline)
approved these changes
Jul 22, 2021
Author
|
Kim-Adeline Miguel (@kimadeline) Hi, I create issue (But i don't have premission to mark label) and news entry md file. |
Kim-Adeline Miguel (kimadeline)
added
the
skip tests
Kartik Raj (karrtikr)
approved these changes
Jul 23, 2021
Kartik Raj (karrtikr)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16765
vscode-test be marked as deprecated on npmjs.org(yarnpkg.com), so just replace vscode-test with latest @vscode/test-electron for
vscode-python's CI. cc Kartik Raj (@karrtikr) Karthik Nadig (@karthiknadig) to fix #16765