Skip to content

Conversation

@bfarahdel
Copy link

@bfarahdel bfarahdel commented Jul 15, 2021

For #8406

Settings have been sorted alphabetically.

Open Source Day

BritsHub and others added 2 commits July 15, 2021 14:37
@ghost
Copy link

ghost commented Jul 15, 2021

CLA assistant check
All CLA requirements met.

@github-actions github-actions bot requested a review from karrtikr July 15, 2021 18:47
@github-actions github-actions bot requested a review from karthiknadig July 15, 2021 18:47
@eleanorjboyd eleanorjboyd changed the title Issue #8406 Sort Settings Alphabetically #8406 Jul 15, 2021
@karthiknadig
Copy link
Member

@bfarahdel Thanks for the PR. Can you sort the items under "commands", "configuration", "properties"... by the name of the command, or configuration.

@karthiknadig
Copy link
Member

This looks good. Waiting for the tests to pass.

@karthiknadig
Copy link
Member

@bfarahdel One last thing so you can get credit for this in our change logs. The error you see means that you need a news item. Add a file 8406.md to news\3 Code Health with the following content:

Sort Settings Alphabetically (thanks [bfarahdel](https://github.com/bfarahdel))

news item
@kimadeline kimadeline added the skip package*.json package.json and package-lock.json don't both need updating label Jul 15, 2021
@karthiknadig karthiknadig merged commit d78ceea into microsoft:main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip package*.json package.json and package-lock.json don't both need updating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants