Skip to content

Fix npm audit vulnerabilities #16658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
paulacamargo25 wants to merge 17 commits into from
Closed

Fix npm audit vulnerabilities #16658

paulacamargo25 wants to merge 17 commits into from

Conversation

@paulacamargo25
Copy link

@paulacamargo25 paulacamargo25 commented Jul 12, 2021 •
edited
Loading

Closed #318.

@paulacamargo25 paulacamargo25 added the no-changelog No news entry required label Jul 12, 2021
@brettcannon brettcannon reopened this Jul 13, 2021
@karthiknadig karthiknadig self-requested a review July 14, 2021 20:12
karthiknadig
karthiknadig reviewed Jul 15, 2021
View reviewed changes
@paulacamargo25 paulacamargo25 marked this pull request as ready for review July 15, 2021 21:34
@karrtikr karrtikr removed their request for review July 15, 2021 22:55
@github-actions github-actions bot requested a review from karrtikr July 15, 2021 22:55
karrtikr
karrtikr reviewed Jul 19, 2021
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I have left one comment which needs verification and tests that needs to be fixed.

@paulacamargo25 paulacamargo25 force-pushed the 16148-Fix-npm-audit-vulnerabilities branch from f240a22 to d3cfa6e Compare July 21, 2021 22:20
@paulacamargo25 paulacamargo25 force-pushed the 16148-Fix-npm-audit-vulnerabilities branch from beaaa84 to f2515cb Compare July 26, 2021 20:00
@paulacamargo25 paulacamargo25 requested a review from karrtikr July 27, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

@kimadeline kimadeline Awaiting requested review from kimadeline

1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@paulacamargo25 paulacamargo25

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paulacamargo25 @karthiknadig @karrtikr @kimadeline @brettcannon