Skip to content

Conversation

@karrtikr
Copy link

@karrtikr karrtikr commented Jul 3, 2021

Closes https://github.com/microsoft/vscode-python-internalbacklog/issues/290 closes https://github.com/microsoft/vscode-python-internalbacklog/issues/300

Key changes:

  • We do all resolving in the environments resolver itself using resolverUtils.ts:
    • Factored out resolvers from low-level locators into a general resolver flat function.
    • Remove resolveEnv from ILocator interface.
  • Ensure we only attempt to locate conda binary once per session whether it happens in resolver or locator.
  • Change resolveEnv prototype to only accept a string.

@karrtikr karrtikr added the no-changelog No news entry required label Jul 3, 2021
@karrtikr karrtikr marked this pull request as ready for review July 8, 2021 00:49
@karrtikr karrtikr requested a review from karthiknadig July 8, 2021 00:54
@karrtikr karrtikr changed the title Factor out resolver from low-level locators into environments resolver Make environment resolving faster Jul 8, 2021
@karrtikr karrtikr changed the title Make environment resolving faster Make environment resolving faster by separating resolvers from locators Jul 8, 2021
@karrtikr karrtikr merged commit 9596b52 into microsoft:main Jul 9, 2021
@karrtikr karrtikr deleted the fixResolver branch July 9, 2021 18:36
karrtikr pushed a commit that referenced this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants