Skip to content

Telemetry to capture the type of terminal being used #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 2 commits into from
May 11, 2018
Merged

Telemetry to capture the type of terminal being used #1650

DonJayamanne merged 2 commits into from
May 11, 2018

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented May 10, 2018

Fixes #1561

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)

@codecov
Copy link

codecov bot commented May 10, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f18a5ee). Click here to learn what that means.
The diff coverage is 97.77%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1650   +/-   ##
========================================
  Coverage          ?   71.4%           
========================================
  Files             ?     277           
  Lines             ?   12903           
  Branches          ?    2319           
========================================
  Hits              ?    9214           
  Misses            ?    3555           
  Partials          ?     134
Impacted Files Coverage Δ
src/client/common/enumUtils.ts 100% <100%> (ø)
src/client/extension.ts 96.18% <100%> (ø)
src/client/common/terminal/helper.ts 98.7% <100%> (ø)
src/client/common/terminal/types.ts 100% <100%> (ø)
...on/terminal/environmentActivationProviders/bash.ts 91.89% <90.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18a5ee...aeb4d3e. Read the comment docs.

@DonJayamanne DonJayamanne merged commit fe442f9 into microsoft:master May 11, 2018
@DonJayamanne DonJayamanne deleted the issue1561TerminalTelemetry branch June 20, 2018 03:17
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MikhailArkhipov MikhailArkhipov MikhailArkhipov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Log what terminal people are using

2 participants

@DonJayamanne @MikhailArkhipov