Skip to content

Fix Pylance Python 2 mistake #16246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karthiknadig merged 1 commit into from
May 14, 2021
+4 −3
Merged

Fix Pylance Python 2 mistake #16246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/client/activation/activationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,9 +250,10 @@ export class LanguageServerExtensionActivationService
}
}

// If "Pylance" was explicitly chosen, use it even though it's not guaranteed to work
// properly with Python 2.
if (!this.getCurrentLanguageServerTypeIsDefault()) {
// If Pylance was chosen via the default and the interpreter is Python 2, fall back to
// Jedi. If Pylance was explicitly chosen, continue anyway, even if Pylance won't work
// as expected, matching pre-default behavior.
if (this.getCurrentLanguageServerTypeIsDefault()) {
if (serverType === LanguageServerType.Node && interpreter && interpreter.version) {
if (interpreter.version.major < 3) {
sendTelemetryEvent(EventName.JEDI_FALLBACK);
Expand Down