Unit tests for evaluating expressions in the experimental debugger #1579
Conversation
| debugClient.assertStoppedLocation('breakpoint', breakpointLocation) | ||
| ]); | ||
|
|
||
| //Do not remove this, this is required to ensure PTVSD is ready to accept other requests. |
There was a problem hiding this comment.
In .NET there is a notion of a unit test 'cleanup' method that runs after each unit test method. Aside from the problems that kind of architecture causes (removes the clarity of flow from the unit test a bit) it can be a very useful tool in cases like this where something must run after a test completes.
Does this unit test framework have that available?
There was a problem hiding this comment.
yes, please look at teardown (towards the top of the file).
There was a problem hiding this comment.
Ah ok, I see what's going on then. Some tests require the code you've added in this PR, others do not. There is a 'wait' added after each test to ensure things get back to where they need to be before the next test runs.
Is this a source of test reliability problems in the past?
d3r3kk
left a comment
d3r3kk
left a comment
There was a problem hiding this comment.
Seems fine. Please have a look at my comment and let me know if that is something worth pursuing.
2 participants
Fixes #1109
This pull request: