Skip to content

Drop prompt displayed on first extension launch #15648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kimadeline merged 2 commits into from
Mar 15, 2021
Merged

Drop prompt displayed on first extension launch #15648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
630c5eb
Drop prompt displayed on first extension launch
Mar 11, 2021
71d3536
Remove files from .eslintignore
Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ src/test/interpreters/pythonPathUpdaterFactory.unit.test.ts
src/test/interpreters/activation/service.unit.test.ts
src/test/interpreters/helpers.unit.test.ts
src/test/interpreters/currentPathService.unit.test.ts
src/test/interpreters/display/interpreterSelectionTip.unit.test.ts
src/test/interpreters/display.unit.test.ts

src/test/configuration/interpreterSelector/interpreterSelector.unit.test.ts
Expand Down Expand Up @@ -313,7 +312,6 @@ src/client/interpreter/autoSelection/rules/system.ts
src/client/interpreter/activation/service.ts
src/client/interpreter/display/shebangCodeLensProvider.ts
src/client/interpreter/display/index.ts
src/client/interpreter/display/interpreterSelectionTip.ts

src/client/api.ts
src/client/extension.ts
Expand Down
1 change: 1 addition & 0 deletions news/1 Enhancements/15647.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Drop prompt being displayed on first extension launch with a tip or a survey.
7 changes: 0 additions & 7 deletions src/client/common/experiments/groups.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,6 @@ export enum TryPylance {
jediPrompt2 = 'tryPylancePromptText2',
}

// Experiment for the content of the tip being displayed on first extension launch:
// interpreter selection tip, feedback survey or nothing.
export enum SurveyAndInterpreterTipNotification {
tipExperiment = 'pythonTipPromptWording',
surveyExperiment = 'pythonMailingListPromptWording',
}

// Experiment to switch Jedi to use an LSP instead of direct providers
export enum JediLSP {
experiment = 'pythonJediLSP',
Expand Down
83 changes: 0 additions & 83 deletions src/client/interpreter/display/interpreterSelectionTip.ts
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions src/client/interpreter/serviceRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import {
IShebangCodeLensProvider,
} from './contracts';
import { InterpreterDisplay } from './display';
import { InterpreterSelectionTip } from './display/interpreterSelectionTip';
import { InterpreterLocatorProgressStatubarHandler } from './display/progressDisplay';
import { ShebangCodeLensProvider } from './display/shebangCodeLensProvider';
import { InterpreterHelper } from './helpers';
Expand Down Expand Up @@ -86,10 +85,6 @@ export function registerInterpreterTypes(serviceManager: IServiceManager): void
serviceManager.addSingleton<IInterpreterSecurityService>(IInterpreterSecurityService, InterpreterSecurityService);

serviceManager.addSingleton<IExtensionActivationService>(IExtensionActivationService, VirtualEnvironmentPrompt);
serviceManager.addSingleton<IExtensionSingleActivationService>(
IExtensionSingleActivationService,
InterpreterSelectionTip,
);

serviceManager.addSingleton<IInterpreterVersionService>(IInterpreterVersionService, InterpreterVersionService);

Expand Down
85 changes: 0 additions & 85 deletions src/test/interpreters/display/interpreterSelectionTip.unit.test.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/test/interpreters/serviceRegistry.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import {
IShebangCodeLensProvider,
} from '../../client/interpreter/contracts';
import { InterpreterDisplay } from '../../client/interpreter/display';
import { InterpreterSelectionTip } from '../../client/interpreter/display/interpreterSelectionTip';
import { InterpreterLocatorProgressStatubarHandler } from '../../client/interpreter/display/progressDisplay';
import { ShebangCodeLensProvider } from '../../client/interpreter/display/shebangCodeLensProvider';
import { InterpreterHelper } from '../../client/interpreter/helpers';
Expand All @@ -74,7 +73,6 @@ suite('Interpreters - Service Registry', () => {
[IInterpreterSecurityService, InterpreterSecurityService],

[IExtensionActivationService, VirtualEnvironmentPrompt],
[IExtensionSingleActivationService, InterpreterSelectionTip],

[IInterpreterVersionService, InterpreterVersionService],

Expand Down