Skip to content

Fix flaky CI failure: Command 'workbench.action.closeAllEditors' timed out #15322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karrtikr merged 1 commit into from
Feb 9, 2021
Merged

Fix flaky CI failure: Command 'workbench.action.closeAllEditors' timed out #15322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/initialize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ async function closeWindowsInteral() {
// Lets not waste too much time.
const timer = setTimeout(() => {
reject(new Error("Command 'workbench.action.closeAllEditors' timed out"));
}, 2000);
Copy link

@rchiodo rchiodo Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will fix it. If it times out it might still take longer. I believe it never returns. But worth a shot.

Copy link
Author

@karrtikr karrtikr Feb 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimadeline @rchiodo I think it does return within 15 seconds, as we did not have this error before #15208 where we decreased the timeout. So it should fix the error.

I'll use #15208 (comment) to fix it otherwise.

}, 15000);
vscode.commands.executeCommand('workbench.action.closeAllEditors').then(
() => {
clearTimeout(timer);
Expand Down