Skip to content

Fix unittest discovery when using VS Code Insiders by using Inversify's skipBaseClassChecks option. #15049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kimadeline merged 3 commits into from
Jan 4, 2021
Merged

Fix unittest discovery when using VS Code Insiders by using Inversify's skipBaseClassChecks option. #15049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adf5adb
Use skipBaseClassChecks
Dec 23, 2020
8a31207
News item
Dec 23, 2020
2fe60cd
Merge branch 'main' into 14962-unittest-macos
Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/14962.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix unittest discovery when using VS Code Insiders by using Inversify's `skipBaseClassChecks` option.
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,7 +1997,7 @@
"glob": "^7.1.2",
"hash.js": "^1.1.7",
"iconv-lite": "^0.4.21",
"inversify": "^4.11.1",
"inversify": "^5.0.4",
"jsonc-parser": "^2.0.3",
"line-by-line": "^0.1.6",
"lodash": "^4.17.19",
Expand Down
2 changes: 1 addition & 1 deletion src/client/extensionInit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function initializeGlobals(
// This is stored in ExtensionState.
context: IExtensionContext,
): ExtensionState {
const cont = new Container();
const cont = new Container({ skipBaseClassChecks: true });
const serviceManager = new ServiceManager(cont);
const serviceContainer = new ServiceContainer(cont);
const disposables: IDisposableRegistry = context.subscriptions;
Expand Down