Only activate discovery component when in experiment#14985
Only activate discovery component when in experiment#14985karrtikr merged 1 commit intomicrosoft:release-2020.12from
Conversation
Codecov Report
@@ Coverage Diff @@
## release-2020.12 #14985 +/- ##
==================================================
Coverage ? 65%
==================================================
Files ? 555
Lines ? 26131
Branches ? 3708
==================================================
Hits ? 17088
Misses ? 8352
Partials ? 691 |
kimadeline
left a comment
kimadeline
left a comment
There was a problem hiding this comment.
Should we delete it all instead of commenting it?
|
@kimadeline I wanted to leave it there so it's easier to explain what the comment is referring to. I feel this may only be a temporary change. |
|
The explanation could have lived in the PR description, and if this had turned out to be a temporary change then this PR could have been reverted (easily visible in the commit history), instead of having to make a separate commit (disconnected from the original one in the commit history). In any case, not a big deal (and this is already merged). |
|
Okay I'll add it to the PR description. I don't feel it is temporary in the sense that this PR will need to be reverted, but in the sense we'll change this code again soon enough, so a separate commit is fine I think. |
* Revert "Add a locator for executables on $PATH on Windows. (#14981) This reverts commit 651a6b9. Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * Version and changelog update (#14982) * Only activate discovery component when in experiment (#14985) * Update version and changelog (#14986) * Update version and changelog * Update package and package.lock json Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
4 participants
For #14977
Add activating using component adapter later if needed: #14984
The old code is left there so it's easier to explain what the comment is referring to, and we can address the above using the reference.