Skip to content

Retrigger discovery in background if some env has changed#14944

Merged
karrtikr merged 1 commit intomicrosoft:mainfrom
karrtikr:useoncahnged
Dec 14, 2020
Merged

Retrigger discovery in background if some env has changed#14944
karrtikr merged 1 commit intomicrosoft:mainfrom
karrtikr:useoncahnged

Conversation

@karrtikr
Copy link

@karrtikr karrtikr commented Dec 11, 2020

Currently we're not making use of api.onChanged at all.

@karrtikr karrtikr added the no-changelog No news entry required label Dec 11, 2020
@karrtikr karrtikr requested review from karthiknadig and removed request for int19h December 11, 2020 00:20
@karrtikr karrtikr changed the title Retrigger discovery in background if something has changed Retrigger discovery in background if some env has changed Dec 11, 2020
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Good call, BTW.

@karrtikr karrtikr merged commit 7f0b0d4 into microsoft:main Dec 14, 2020
@karrtikr karrtikr deleted the useoncahnged branch December 14, 2020 17:40
karrtikr pushed a commit to karrtikr/vscode-python that referenced this pull request Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants