Skip to content

Cherry-pick fixes for #14676, #12462 into release-2020.11 #14748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
int19h merged 1 commit into from
Nov 16, 2020
Merged

Cherry-pick fixes for #14676, #12462 into release-2020.11 #14748

int19h merged 1 commit into from
Nov 16, 2020

Conversation

@int19h
Copy link

@int19h int19h commented Nov 16, 2020

Originally reviewed in #14676

@int19h
Fix microsoft#14674: Enable overriding "pythonPath" in the launcher (m…
0d995b5 
…icrosoft#14676)

Fix microsoft#12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath".
@int19h int19h added the no-changelog No news entry required label Nov 16, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link

codecov-io commented Nov 16, 2020 •
edited
Loading

Codecov Report

Merging #14748 (0d995b5) into release-2020.11 (171ffd0) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.11   #14748      +/-   ##
===================================================
- Coverage            65.01%   65.01%   -0.01%     
===================================================
  Files                  543      543              
  Lines                25429    25448      +19     
  Branches              3593     3599       +6     
===================================================
+ Hits                 16533    16545      +12     
- Misses                8219     8225       +6     
- Partials               677      678       +1
Impacted Files Coverage Δ
...tension/configuration/debugConfigurationService.ts 71.42% <0.00%> (-7.52%) ⬇️
...c/client/debugger/extension/configuration/types.ts 100.00% <ø> (ø)
src/client/debugger/types.ts 100.00% <ø> (ø)
src/client/testing/common/debugLauncher.ts 90.82% <60.00%> (-1.63%) ⬇️
...bugger/extension/configuration/resolvers/launch.ts 91.57% <95.83%> (+0.66%) ⬆️
...on/diagnostics/checks/invalidLaunchJsonDebugger.ts 94.18% <100.00%> (+0.06%) ⬆️
src/client/debugger/extension/adapter/factory.ts 94.11% <100.00%> (+0.24%) ⬆️
...bugger/extension/configuration/resolvers/attach.ts 80.00% <100.00%> (ø)
...debugger/extension/configuration/resolvers/base.ts 91.25% <100.00%> (+0.22%) ⬆️
src/client/common/utils/platform.ts 68.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171ffd0...0d995b5. Read the comment docs.

@int19h int19h merged commit dfd7cf1 into microsoft:release-2020.11 Nov 16, 2020
@int19h int19h deleted the pcp branch November 16, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@int19h @codecov-io @karthiknadig