forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Put linter prompt behind experiment #14731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimadeline
approved these changes
Nov 17, 2020
karrtikr
approved these changes
Nov 18, 2020
karrtikr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add a news entry regarding the experiment I think.
|
Kudos, SonarCloud Quality Gate passed!
|
karthiknadig
added a commit
to karthiknadig/vscode-python
that referenced
this pull request
Nov 19, 2020
* Add new linter prompt * Tests * Fix typos * Show linter install message only once. * Add more tests and news
karthiknadig
added a commit
that referenced
this pull request
Nov 19, 2020
* Add new tryPylance banner experiments (#14759) Co-authored-by: Bill Schnurr <bschnurr@microsoft.com> * Put linter prompt behind experiment (#14731) * Add new linter prompt * Tests * Fix typos * Show linter install message only once. * Add more tests and news * Updates for point release. Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Co-authored-by: Bill Schnurr <bschnurr@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #14760