Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
# Changelog

## 2020.11.0-rc (4 November 2020)
## 2020.11.0 (11 November 2020)

### Enhancements

UPDATE THIS BEFORE RELEASE
1. Update shipped debugger wheels to python 3.8.
([#14614](https://github.com/Microsoft/vscode-python/issues/14614))

### Fixes

Expand All @@ -15,6 +16,10 @@ UPDATE THIS BEFORE RELEASE
1. When sending code to the REPL, read input from `sys.stdin` instead of passing it as an argument.
([#14471](https://github.com/Microsoft/vscode-python/issues/14471))

### Code Health

1. Code for Jupyter Notebooks support has been refactored into the Jupyter extension, which is now a dependency for the Python extension

### Thanks

Thanks to the following projects which we fully rely on to provide some of
Expand Down
Binary file modified images/ConfigureDebugger.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/ConfigureTests.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/InterpreterSelectionZoom.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/OpenOrCreateNotebook.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion news/1 Enhancements/14614.md

This file was deleted.

2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "python",
"displayName": "Python",
"description": "Linting, Debugging (multi-threaded, remote), Intellisense, Jupyter Notebooks, code formatting, refactoring, unit tests, snippets, and more.",
"version": "2020.11.0-rc",
"version": "2020.11.0",
"featureFlags": {
"usingNewInterpreterStorage": true
},
Expand Down
15 changes: 15 additions & 0 deletions src/client/common/configSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,21 @@ export class PythonSettings implements IPythonSettings {
PythonSettings.pythonSettings.forEach((item) => item && item.dispose());
PythonSettings.pythonSettings.clear();
}

public static toSerializable(settings: IPythonSettings): IPythonSettings {
// tslint:disable-next-line: no-any
const clone: any = {};
const keys = Object.entries(settings);
keys.forEach((e) => {
const [k, v] = e;
if (!k.includes('Manager') && !k.includes('Service') && !k.includes('onDid')) {
clone[k] = v;
}
});

return clone as IPythonSettings;
}

public dispose() {
// tslint:disable-next-line:no-unsafe-any
this.disposables.forEach((disposable) => disposable && disposable.dispose());
Expand Down
15 changes: 3 additions & 12 deletions src/client/common/startPage/webviewHost.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import * as localize from '../utils/localize';
import { DefaultTheme, Telemetry } from './constants';
import { ICodeCssGenerator, IThemeFinder } from './types';

import { PythonSettings } from '../configSettings';
import { isTestExecution } from '../constants';
import { IConfigurationService, IDisposable, IPythonSettings, Resource } from '../types';
import { CssMessages, IGetCssRequest, IGetMonacoThemeRequest, SharedMessages } from './messages';
Expand Down Expand Up @@ -104,18 +105,8 @@ export abstract class WebviewHost<IMapping> implements IDisposable {
}

protected async generateExtraSettings(): Promise<IPythonSettings> {
const resource = this.owningResource;
// tslint:disable-next-line: no-any
const prunedSettings = this.configService.getSettings(resource) as any;

// Remove keys that aren't serializable
const keys = Object.keys(prunedSettings);
keys.forEach((k) => {
if (k.includes('Manager') || k.includes('Service') || k.includes('onDid')) {
delete prunedSettings[k];
}
});
return prunedSettings;
const settings = this.configService.getSettings(this.owningResource);
return PythonSettings.toSerializable(settings);
}

protected async sendLocStrings() {
Expand Down