Skip to content

Add node loader #14692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karthiknadig merged 3 commits into from
Nov 11, 2020
Merged

Add node loader #14692

karthiknadig merged 3 commits into from
Nov 11, 2020

Conversation

@karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Nov 11, 2020

For #14664

@codecov-io
Copy link

codecov-io commented Nov 11, 2020 •
edited
Loading

Codecov Report

Merging #14692 (767ff25) into main (cae62fd) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14692      +/-   ##
==========================================
- Coverage   64.89%   64.86%   -0.03%     
==========================================
  Files         547      547              
  Lines       25611    25611              
  Branches     3619     3619              
==========================================
- Hits        16619    16612       -7     
- Misses       8311     8313       +2     
- Partials      681      686       +5
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 53.33% <0.00%> (-10.00%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
.../pythonEnvironments/common/externalDependencies.ts 70.21% <0.00%> (-2.13%) ⬇️
.../locators/services/virtualEnvironmentIdentifier.ts 90.41% <0.00%> (-1.37%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/common/configSettings.ts 69.55% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cae62fd...767ff25. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@karthiknadig karthiknadig mentioned this pull request Nov 11, 2020
Merged
@karthiknadig karthiknadig merged commit 79d6632 into microsoft:main Nov 11, 2020
@karthiknadig karthiknadig deleted the build1 branch December 10, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@int19h int19h Awaiting requested review from int19h

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karthiknadig @codecov-io @karrtikr