Skip to content

Disable mailing list if running in codespaces #14347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joyceerhl merged 1 commit into from
Oct 9, 2020
Merged

Disable mailing list if running in codespaces #14347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/client/application/misc/joinMailingListPrompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import { inject, injectable } from 'inversify';
import * as querystring from 'querystring';
import { env, UIKind } from 'vscode';
import { IExtensionSingleActivationService } from '../../activation/types';
import { IApplicationEnvironment, IApplicationShell } from '../../common/application/types';
import { JoinMailingListPromptVariants } from '../../common/experiments/groups';
Expand All @@ -28,9 +29,9 @@ export class JoinMailingListPrompt implements IExtensionSingleActivationService

public async activate(): Promise<void> {
// Only show the prompt if we have never shown it before. True here, means we have
// shown the prompt before.
if (this.storage.value) {
return Promise.resolve();
// shown the prompt before. Also do not show the prompt if running in Codespaces.
if (this.storage.value || env.uiKind === UIKind?.Web) {
return;
}

let promptContent: string | undefined;
Expand Down