Fix sample notebook to state that you can double click to edit a cell #14238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceerhl
requested review from
DavidKutu,
DonJayamanne,
IanMatthewHuff and
rchiodo
rchiodo
approved these changes
Oct 2, 2020
Codecov Report
@@ Coverage Diff @@
## main #14238 +/- ##
=======================================
Coverage 59.95% 59.95%
=======================================
Files 706 706
Lines 39183 39181 -2
Branches 5681 5681
=======================================
- Hits 23493 23492 -1
+ Misses 14453 14452 -1
Partials 1237 1237
Continue to review full report at Codecov.
|
DavidKutu
approved these changes
Oct 2, 2020
IanMatthewHuff
approved these changes
Oct 2, 2020
| "You are currently viewing what we call our Notebook Editor. It is an interactive document based on Jupyter Notebooks that supports the intermixing of code, outputs and markdown documentation. \n", | ||
| "\n", | ||
| "This cell is a markdown cell. To edit the text in this cell, simply click on the cell to change it into edit mode.\n", | ||
| "This cell is a markdown cell. To edit the text in this cell, simply double click on the cell to change it into edit mode.\n", |
Member
There was a problem hiding this comment.
This PR actually made me look up if there was supposed to be a hyphen here or not. The internet seems a bit unsure, so I vote we go ahead with this.
DonJayamanne
approved these changes
Oct 2, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
pushed a commit
that referenced
this pull request
Oct 30, 2020
…-jupyter (#194) * Fix sample notebook to state that you can double click to edit a cell (#14238) * Disable surveys if running in codespaces (#14332) * Disable surveys if running in codespaces * Disable gather survey in codespaces too * For gather, show a description without the survey * Fixes for IW tests where UIKind is not defined * Fix all the tests where UIKind is not defined * Appease hygiene * Disable mailing list if running in Codespaces (#14347) * Show tensor dimensions in variable explorer (#14244) * Fix markdown cell marker formatting for export to Python (#14360)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/microsoft/vscode-python/issues/14112
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).