Skip to content

Remove control tower code for trusted notebooks #13394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joyceerhl merged 2 commits into from
Aug 12, 2020
Merged

Remove control tower code for trusted notebooks #13394

joyceerhl merged 2 commits into from
Aug 12, 2020

Conversation

@joyceerhl
Copy link

@joyceerhl joyceerhl commented Aug 12, 2020

For #12920

This reverses #12712 and #12789 since the feature has been fully rolled out to 100% of customers.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added the no-changelog No news entry required label Aug 12, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020 •
edited
Loading

Codecov Report

Merging #13394 into master will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13394      +/-   ##
==========================================
- Coverage   59.95%   59.92%   -0.04%     
==========================================
  Files         670      670              
  Lines       37200    37186      -14     
  Branches     5311     5309       -2     
==========================================
- Hits        22305    22284      -21     
+ Misses      13773    13763      -10     
- Partials     1122     1139      +17
Impacted Files Coverage Δ
src/client/common/experiments/groups.ts 100.00% <ø> (ø)
...ience/interactive-common/interactiveWindowTypes.ts 100.00% <ø> (ø)
...ient/datascience/interactive-ipynb/nativeEditor.ts 8.16% <ø> (-0.25%) ⬇️
src/datascience-ui/interactive-common/mainState.ts 57.14% <ø> (ø)
...ient/datascience/interactive-ipynb/trustService.ts 89.28% <75.00%> (-1.63%) ⬇️
...tascience/interactive-ipynb/trustCommandHandler.ts 78.72% <100.00%> (-1.67%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da06067...2f3bbae. Read the comment docs.

IanMatthewHuff
IanMatthewHuff reviewed Aug 12, 2020
View reviewed changes
src/client/datascience/interactive-ipynb/trustService.ts
if (this.alwaysTrustNotebooks || !(await this.enabled)) {
return true; // Skip check if user manually overrode our trust checking, or if user is not in experiment
if (this.alwaysTrustNotebooks) {
return true; // Skip check if user manually overrode our trust checking
Copy link
Member

@IanMatthewHuff IanMatthewHuff Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated comments 👍

@joyceerhl joyceerhl merged commit 032ebce into microsoft:master Aug 12, 2020
@joyceerhl joyceerhl mentioned this pull request Aug 13, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@greazer greazer Awaiting requested review from greazer

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joyceerhl @codecov-commenter @IanMatthewHuff @rchiodo