A bunch of fixes for nightly tests #13099
Conversation
rchiodo
requested review from
DavidKutu,
DonJayamanne,
IanMatthewHuff,
greazer,
joyceerhl and
techwithtim
Codecov Report
@@ Coverage Diff @@
## master #13099 +/- ##
==========================================
- Coverage 59.77% 59.76% -0.01%
==========================================
Files 671 671
Lines 36686 36688 +2
Branches 5158 5158
==========================================
- Hits 21928 21927 -1
- Misses 13663 13665 +2
- Partials 1095 1096 +1
Continue to review full report at Codecov.
|
.vscode/launch.json
Outdated
| "--recursive", | ||
| "--colors", | ||
| //"--grep", "<suite name>", | ||
| "--grep", "Multiple Interpreters", |
There was a problem hiding this comment.
Still a work in progress?
btw, I don't mind leaving this here
| return Promise.resolve(a4); | ||
| } | ||
| }); | ||
| appShell |
There was a problem hiding this comment.
This is not right, or at least not how it currently works. I was starting to look into this yesterday. The Remote tests have a rebind function for changing the appShell. I added the showWarningMessage overrider there, and they passed locally. However after the interactive window test changes the test is now not using the rebind function. Seems like the timing might have been changed as I could still see the per test rebind function getting hit, but when the test executed it was using the default IOC appshell. I think we need it per test still as I added a test that expects the 'no' a3 answer.
There was a problem hiding this comment.
Remote deny insecure test is still passing though.
There was a problem hiding this comment.
Oh it's passing because the test doesn't check for a failure. Yeah the rebind happens too late. It's after the jupyterSessionManagerFactory has been created.
There was a problem hiding this comment.
It must have thrown a different exception then. I'm fixing the binding problem.
There was a problem hiding this comment.
I had the test use expectError, but maybe that just allows for an error, as opposed to requiring one? I should have tested that with a broken case before submitting it.
|
Kudos, SonarCloud Quality Gate passed!
|
5 participants
Nightly flake failed with some new failures (and one old failure) last night