Skip to content

Fix linting.pylintEnabled setting check #12444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kimadeline merged 2 commits into from
Jun 22, 2020
Merged

Fix linting.pylintEnabled setting check #12444

kimadeline merged 2 commits into from
Jun 22, 2020

Conversation

@kimadeline
Copy link

@kimadeline kimadeline commented Jun 19, 2020

For #12285

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 19, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 2 Security Hotspots to review)
Code Smell A 19 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kimadeline kimadeline merged commit 65f9709 into microsoft:master Jun 22, 2020
@kimadeline kimadeline deleted the 12285-pylint-setting-mpls branch June 22, 2020 18:16
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Jun 24, 2020
@kimadeline @karthiknadig
Fix linting.pylintEnabled setting check (microsoft#12444)
5f9e828 
* Fix `linting.pylintEnabled` setting check
* Use stub instead of handspun variable
karthiknadig added a commit that referenced this pull request Jun 25, 2020
@karthiknadig @kimadeline @jakebailey
Hot fixes for pylint and jediEnabled issues (#12556)
9deec1a 
* Fix `linting.pylintEnabled` setting check (#12444)

* Fix `linting.pylintEnabled` setting check
* Use stub instead of handspun variable

* Don't modify LS settings if jediEnabled does not exist (#12551)

* Update change logs and version

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

+1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kimadeline @karthiknadig @karrtikr