Skip to content

Fix handle continue to match cell #12211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanMatthewHuff merged 1 commit into from
Jun 9, 2020
Merged

Fix handle continue to match cell #12211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/12155.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix debugger continue event to actually change a cell.
6 changes: 3 additions & 3 deletions src/client/datascience/interactive-ipynb/nativeEditorRunByLineListener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,18 +105,18 @@ export class NativeEditorRunByLineListener

private async handleStep() {
// User issued a step command.
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined });
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun });
return this.debugService.step();
}

private async handleContinue() {
// User issued a continue command
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined });
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun });
return this.debugService.continue();
}

private async handleContinueEvent() {
// Tell the ui to erase the current IP
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined });
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun });
Copy link
Member Author

@IanMatthewHuff IanMatthewHuff Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This event was hooked up previously, but wasn't passing in a payload so it wasn't changing the cell in the reducer.

}
}