Lazy load types from @jupyterlab and similar modules #11298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
requested review from
DavidKutu,
IanMatthewHuff,
greazer and
rchiodo
|
SonarCloud Quality Gate failed.
|
| this._status = 'unknown'; | ||
| this._statusChanged = new Signal<this, Kernel.Status>(this); | ||
| // tslint:disable-next-line: no-require-imports | ||
| const signalling = require('@phosphor/signaling') as typeof import('@phosphor/signaling'); |
IanMatthewHuff
approved these changes
Apr 21, 2020
Member
IanMatthewHuff
left a comment
IanMatthewHuff
left a comment
There was a problem hiding this comment.
Just one misspell. Looks good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11279