Fix pdf viewer so that we just ship the standalone version.#11192
Merged
Fix pdf viewer so that we just ship the standalone version.#11192
Conversation
rchiodo
requested review from
DavidKutu,
DonJayamanne,
IanMatthewHuff and
greazer
|
Kudos, SonarCloud Quality Gate passed!
|
DavidKutu
approved these changes
Apr 15, 2020
DonJayamanne
approved these changes
Apr 15, 2020
rchiodo
added a commit
that referenced
this pull request
Apr 15, 2020
rchiodo
added a commit
that referenced
this pull request
Apr 15, 2020
* Fix pdf viewer so that we just ship the standalone version. (#11192) * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #11157
Recent update to pdfkit broke saving but only when the full extension is built. Fixed this to use the pdfkit.standalone which doesn't have any other dependencies so we don't have to special package up fontkit.