Port perf fix to release branch#11144
Merged
rchiodo merged 3 commits intorelease-2020.04from Apr 14, 2020
Merged
Conversation
* Eliminate first level of redundancy * Working with a cache * Add test to verify no more generating cell ranges * Add news entry * Clean up on closing * Make sure close and reopen works * Fix sonar errors * Fix restart * Fix wrong IDisposable type * Rename restartedKernel to onKernelRestarted * Recompute when changing settings * Clear out document close event when document closes
rchiodo
requested review from
DavidKutu,
DonJayamanne,
IanMatthewHuff and
karthiknadig
IanMatthewHuff
approved these changes
Apr 14, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## release-2020.04 #11144 +/- ##
===================================================
- Coverage 61.41% 61.37% -0.05%
===================================================
Files 597 596 -1
Lines 32761 32786 +25
Branches 4633 4642 +9
===================================================
Hits 20121 20121
- Misses 11624 11645 +21
- Partials 1016 1020 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See original PR:
#11142