Conversation
rchiodo
requested review from
DavidKutu,
DonJayamanne,
IanMatthewHuff and
karrtikr
| InterpeterHashProviderFactory, | ||
| InterpeterHashProviderFactory | ||
| ); | ||
| this.serviceManager.addSingleton<IInterpreterSecurityService>( |
There was a problem hiding this comment.
@karrtikr unfortunately the real interpreter services are registered when we use real jupyter, so these additions were in the wrong spot. They had to fall under the if for when not using the real jupyter.
There was a problem hiding this comment.
unfortunately the real interpreter services are registered
I see. But do these real interpreter services do not need to register IInterpreterSecurityService? Or was it the case that it was being registered twice?
There was a problem hiding this comment.
It was being registered twice when using real jupyter (causing an ambiguous match exception)
|
Kudos, SonarCloud Quality Gate passed!
|
|
Going to port this to release |
3 participants
For #11060
I had removed this by accident on my refactor for how widgets were rendered.
Also fixed a problem with the functional tests running with real jupyter (caused by the IInterpreterSecurity stuff). @karrtikr you fixed the functional tests when running without jupyter, but it's a little bit more tricky than that. Some of our services a registered differently when using real jupyter (Nightly Flake tests)