Skip to content

Resize plot to fit within pdf page #10547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonJayamanne merged 3 commits into from
Mar 13, 2020
Merged

Resize plot to fit within pdf page #10547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00cffe8
Ensure plot fits within page
DonJayamanne Mar 13, 2020
022c5ea
No var
DonJayamanne Mar 13, 2020
df72d94
Retry
DonJayamanne Mar 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/9403.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Ensure plot fits within the page of the `PDF`.
6 changes: 4 additions & 2 deletions src/client/datascience/plotting/plotViewer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,14 @@ export class PlotViewer extends WebViewHost<IPlotViewerMapping> implements IPlot
const SVGtoPDF = require('svg-to-pdfkit');
const deferred = createDeferred<void>();
// tslint:disable-next-line: no-require-imports
const pdfkit = require('pdfkit');
const pdfkit = require('pdfkit') as typeof import('pdfkit');
const doc = new pdfkit();
const ws = this.fileSystem.createWriteStream(file.fsPath);
traceInfo(`Writing pdf to ${file.fsPath}`);
ws.on('finish', () => deferred.resolve);
SVGtoPDF(doc, payload.svg, 0, 0);
// See docs or demo from source https://cdn.statically.io/gh/alafr/SVG-to-PDFKit/master/examples/demo.htm
// How to resize to fit (fit within the height & width of page).
SVGtoPDF(doc, payload.svg, 0, 0, { preserveAspectRatio: 'xMinYMin meet' });
doc.pipe(ws);
doc.end();
traceInfo(`Finishing pdf to ${file.fsPath}`);
Expand Down
2 changes: 1 addition & 1 deletion src/test/datascience/nativeEditor.functional.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2194,7 +2194,7 @@ df.head()`;
await makeChangesAndConfirmFileIsUpdated();
await makeChangesAndConfirmFileIsUpdated();
await makeChangesAndConfirmFileIsUpdated();
});
}).retries(2);

test('File saved with same format', async () => {
// Configure notebook to save automatically ever 1s.
Expand Down