Skip to content

Rename datascience to datascience_modules (#10525)#10528

Merged
rchiodo merged 2 commits intorelease-2020.03from
rchiodo/port_ds_rename
Mar 12, 2020
Merged

Rename datascience to datascience_modules (#10525)#10528
rchiodo merged 2 commits intorelease-2020.03from
rchiodo/port_ds_rename

Conversation

@rchiodo
Copy link

@rchiodo rchiodo commented Mar 11, 2020

@rchiodo
Rename datascience to datascience_modules (#10525)
5c02a19 
* Rename datascience to datascience_modules

* Change name to something even harder to get wrong
@rchiodo rchiodo self-assigned this Mar 11, 2020
@rchiodo rchiodo added the no-changelog No news entry required label Mar 11, 2020
@codecov-io
Copy link

codecov-io commented Mar 11, 2020 •
edited
Loading

Codecov Report

Merging #10528 into release-2020.03 will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.03   #10528      +/-   ##
===================================================
- Coverage            60.86%   60.84%   -0.03%     
===================================================
  Files                  579      579              
  Lines                31290    31291       +1     
  Branches              4449     4450       +1     
===================================================
- Hits                 19045    19039       -6     
- Misses               11282    11287       +5     
- Partials               963      965       +2
Impacted Files Coverage Δ
.../datascience/jupyter/interpreter/jupyterCommand.ts 55.17% <ø> (ø) ⬆️
src/client/datascience/jupyter/jupyterVariables.ts 50.57% <0%> (ø) ⬆️
src/client/datascience/constants.ts 99.71% <100%> (ø) ⬆️
...er/jupyterInterpreterSubCommandExecutionService.ts 83.33% <100%> (ø) ⬆️
...reter/jupyterCommandInterpreterExecutionService.ts 68.88% <100%> (ø) ⬆️
src/client/common/process/pythonDaemonPool.ts 70.58% <100%> (ø) ⬆️
src/client/constants.ts 83.33% <0%> (-16.67%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75% <0%> (-12.5%) ⬇️
src/client/common/utils/platform.ts 64.7% <0%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2603a...737f2a7. Read the comment docs.

@rchiodo rchiodo closed this Mar 12, 2020
@rchiodo rchiodo reopened this Mar 12, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@rchiodo rchiodo merged commit f7cf79b into release-2020.03 Mar 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
@rchiodo rchiodo deleted the rchiodo/port_ds_rename branch April 22, 2020 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@karthiknadig karthiknadig karthiknadig approved these changes

+1 more reviewer

@DavidKutu DavidKutu DavidKutu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rchiodo rchiodo

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rchiodo @codecov-io @IanMatthewHuff @DonJayamanne @karthiknadig @DavidKutu