notify on missing kernel and interpreter with kernel#10508
Merged
IanMatthewHuff merged 1 commit intomicrosoft:masterfrom Mar 10, 2020
Merged
notify on missing kernel and interpreter with kernel#10508IanMatthewHuff merged 1 commit intomicrosoft:masterfrom
IanMatthewHuff merged 1 commit intomicrosoft:masterfrom
Conversation
Member
Author
|
|
IanMatthewHuff
commented
Mar 10, 2020
| if (displayNameOfKernelNotFound && !disableUI) { | ||
| this.applicationShell | ||
| .showInformationMessage( | ||
| localize.DataScience.fallbackToUseActiveInterpeterAsKernel().format( |
Member
Author
There was a problem hiding this comment.
This message already existed and was in unit tests, but not in the product at all. Might have gotten factored out?
rchiodo
approved these changes
Mar 10, 2020
DavidKutu
approved these changes
Mar 10, 2020
DonJayamanne
approved these changes
Mar 10, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #10508 +/- ##
==========================================
- Coverage 60.86% 60.83% -0.03%
==========================================
Files 579 579
Lines 31294 31296 +2
Branches 4451 4452 +1
==========================================
- Hits 19046 19040 -6
- Misses 11285 11290 +5
- Partials 963 966 +3
Continue to review full report at Codecov.
|
DonJayamanne
added a commit
that referenced
this pull request
Mar 13, 2020
* master: Fix flakey file system tests (#10541) Tweaks for gather (#10532) Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517) Add conda support to nightly flake test (#10523) Rename datascience to datascience_modules (#10525) Clean up the extension activation code. (#10455) Allow escape and ctrl+U to clear the interactive window (#10513) Fix builtins so they don't interfere with our execution (#10511) Jupyter autocompletion will only show up on empty lines, (#10420) notify on missing kernel and interpreter with kernel (#10508)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9845
No news as this is just a follow up fix when an issue was noticed in validation.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).