Skip to content

Jupyter autocompletion will only show up on empty lines,#10420

Merged
DavidKutu merged 5 commits intomasterfrom
davidkutu/intellisenseFix
Mar 10, 2020
Merged

Jupyter autocompletion will only show up on empty lines,#10420
DavidKutu merged 5 commits intomasterfrom
davidkutu/intellisenseFix

Conversation

@DavidKutu
Copy link

@DavidKutu DavidKutu commented Mar 3, 2020 •
edited
Loading

instead of appearing in functions.

For #10023

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

Jupyter autocompletion will only show up on empty lines,
58ae8b3 
instead of appearing in functions.
@DavidKutu DavidKutu closed this Mar 3, 2020
@DavidKutu DavidKutu reopened this Mar 3, 2020
rchiodo
rchiodo requested changes Mar 3, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@codecov-io
Copy link

codecov-io commented Mar 3, 2020 •
edited
Loading

Codecov Report

Merging #10420 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10420      +/-   ##
==========================================
- Coverage   60.84%   60.83%   -0.02%     
==========================================
  Files         570      579       +9     
  Lines       30720    31300     +580     
  Branches     4376     4451      +75     
==========================================
+ Hits        18691    19040     +349     
- Misses      11078    11295     +217     
- Partials      951      965      +14
Impacted Files Coverage Δ
...active-common/intellisense/intellisenseProvider.ts 37.09% <0%> (-0.74%) ⬇️
src/client/datascience/gather/gather.ts 32.81% <0%> (-30.35%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75% <0%> (-12.5%) ⬇️
src/client/common/utils/platform.ts 64.7% <0%> (-11.77%) ⬇️
.../datascience/editor-integration/codeLensFactory.ts 58.11% <0%> (-9.89%) ⬇️
src/client/datascience/cellMatcher.ts 79.54% <0%> (-6.82%) ⬇️
...datascience/editor-integration/cellhashprovider.ts 71.03% <0%> (-3.44%) ⬇️
...tascience/interactive-ipynb/nativeEditorStorage.ts 49.36% <0%> (-2.81%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
src/client/datascience/jupyter/jupyterSession.ts 65.35% <0%> (-2.07%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e4a5e...a6a1736. Read the comment docs.

filter out magic commands instead of
24e31f9 
ignoring all the jupyter intellisense.
@DavidKutu DavidKutu requested a review from rchiodo March 4, 2020 17:43
@DavidKutu DavidKutu requested a review from DonJayamanne March 10, 2020 19:07
rchiodo
rchiodo approved these changes Mar 10, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

IanMatthewHuff
IanMatthewHuff requested changes Mar 10, 2020
View reviewed changes
DonJayamanne
DonJayamanne requested changes Mar 10, 2020
View reviewed changes
src/client/datascience/interactive-common/intellisense/intellisenseProvider.ts
};
}

private filterJupyterMatches(
Copy link

@DonJayamanne DonJayamanne Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this method does. sounds very generic.
Please could you add comments about what this method does

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DavidKutu DavidKutu merged commit 66db7ed into master Mar 10, 2020
@DavidKutu DavidKutu deleted the davidkutu/intellisenseFix branch March 10, 2020 22:18
DonJayamanne added a commit that referenced this pull request Mar 13, 2020
@DonJayamanne
Merge branch 'master' into ds/custom_editor
d3c4ad9 
* master:
  Fix flakey file system tests (#10541)
  Tweaks for gather (#10532)
  Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517)
  Add conda support to nightly flake test (#10523)
  Rename datascience to datascience_modules (#10525)
  Clean up the extension activation code. (#10455)
  Allow escape and ctrl+U to clear the interactive window (#10513)
  Fix builtins so they don't interfere with our execution (#10511)
  Jupyter autocompletion will only show up on empty lines, (#10420)
  notify on missing kernel and interpreter with kernel (#10508)
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@rchiodo rchiodo rchiodo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DavidKutu @codecov-io @IanMatthewHuff @DonJayamanne @rchiodo