Skip to content

Fix DS startup and shutdown functional tests #10284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 1 commit into from
Feb 24, 2020
Merged

Fix DS startup and shutdown functional tests #10284

DonJayamanne merged 1 commit into from
Feb 24, 2020

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Feb 24, 2020

No description provided.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 24, 2020
IanMatthewHuff
IanMatthewHuff approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

codecov-io commented Feb 24, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ds/custom_editor@eea3f1c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             ds/custom_editor   #10284   +/-   ##
===================================================
  Coverage                    ?   60.85%           
===================================================
  Files                       ?      570           
  Lines                       ?    30684           
  Branches                    ?     4373           
===================================================
  Hits                        ?    18673           
  Misses                      ?    11057           
  Partials                    ?      954

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea3f1c...332a47e. Read the comment docs.

@DonJayamanne DonJayamanne reopened this Feb 24, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DonJayamanne DonJayamanne merged commit cbb9808 into microsoft:ds/custom_editor Feb 24, 2020
@DonJayamanne DonJayamanne deleted the fixDamnit branch February 24, 2020 18:27
@DonJayamanne DonJayamanne mentioned this pull request Feb 24, 2020
Closed
10 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo