Skip to content

Complete refactoring of creation and queueing of actions #10036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 3 commits into from
Feb 12, 2020
Merged

Complete refactoring of creation and queueing of actions #10036

DonJayamanne merged 3 commits into from
Feb 12, 2020

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Feb 10, 2020 •
edited
Loading

Some how I had not included some of the other remaining arg.queueAction into the original
PR #10019

This PR merely brings them from (I had these in the same branch, but failed to include them).
Same as #10019, just a refactor to use a common function to create an action and dispatch it in one step. & removed some of the old syncing stuff.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 10, 2020
@DonJayamanne DonJayamanne changed the title Some other stuff I missed Complete refactoring of creation and queueing of actions Feb 11, 2020
rchiodo
rchiodo approved these changes Feb 11, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

codecov-io commented Feb 11, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ds/custom_editor@70e2431). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             ds/custom_editor   #10036   +/-   ##
===================================================
  Coverage                    ?   60.82%           
===================================================
  Files                       ?      564           
  Lines                       ?    29872           
  Branches                    ?     4489           
===================================================
  Hits                        ?    18170           
  Misses                      ?    10709           
  Partials                    ?      993
Impacted Files Coverage Δ
...ractive-common/interactiveWindowMessageListener.ts 17.5% <ø> (ø)
.../datascience/interactive-common/interactiveBase.ts 5.75% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e2431...9f5506d. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DonJayamanne DonJayamanne merged commit 4685573 into microsoft:ds/custom_editor Feb 12, 2020
@DonJayamanne DonJayamanne deleted the phase2Again branch February 12, 2020 04:42
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo