Fix LGTM.com alerts - #948
Merged
Rachel Macfarlane (RMacfarlane) merged 6 commits intoFeb 15, 2019
Merged
Conversation
(found on LGTM.com)
(found on LGTM.com)
Only the first instance of back-slash was correctly replaced with forward-slash. (found on LGTM.com)
(found on LGTM.com)
(found on LGTM.com)
(found on LGTM.com)
Rachel Macfarlane (RMacfarlane)
approved these changes
Feb 15, 2019
Rachel Macfarlane (RMacfarlane)
left a comment
Rachel Macfarlane (RMacfarlane)
left a comment
Contributor
There was a problem hiding this comment.
Thank you! LGTM :)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes all of the alerts for this project found by LGTM.com.
The only change that could potentially change behaviour are the fixes to the string replacing in
protocol.ts, everything else is just cleaning up redundant code.The only alerts that would remain after this PR gets merged are false positives for 'Useless assignment to property', which is fixed in github/codeql#920 (and should be deployed to LGTM shortly).
(Full disclosure: I'm part of the team behind LGTM.com)