Fix resolving review threads from the webview#8782
Draft
alexr00 wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes resolving/unresolving review threads from the PR timeline webview by ensuring the UI targets the correct GraphQL review thread when a single review contains comments across multiple threads.
Changes:
- Add
threadId(GraphQL review thread node ID) toICommentwhen parsing comments from GraphQL review threads. - Track resolve/unresolve permissions per review thread (map keyed by thread GraphQL ID) on each
ReviewEvent. - Update the webview timeline to group comments by
threadId(falling back to path+position) and resolve/unresolve the specific thread for that group.
Show a summary per file
| File | Description |
|---|---|
| webviews/components/timeline.tsx | Groups review comments by threadId and resolves the correct thread per rendered comment group. |
| src/github/utils.ts | Propagates GraphQL review thread ID into parsed IComment objects. |
| src/github/pullRequestModel.ts | Populates a per-review map of thread resolve info so the webview can target the correct thread. |
| src/common/timelineEvent.ts | Updates ReviewEvent shape to expose reviewThreads (threadId → resolve info). |
| src/common/comment.ts | Extends IComment with optional threadId to associate comments with their review thread. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.