Add chat participant, tools, and notifications view by alexr00 · Pull Request #6280 · microsoft/vscode-pull-request-github

Alex Ross (alexr00) · 2024-10-15T08:23:32Z

Adds the following AI features:

A githubpr chat participant for handling github related requests
Several lm tools for the participant (or others) to use:
- get issue
- convert text to GH search syntax
- Execute a GH issue/pr search
- Display search results in a markdown table
- Suggest a fix for an issue
A notifications view, with Copilot based sorting

…tool to fix issues if so instructed

…b url

…tion, formatting the prompt

…when can not load more

add a prompt specifically for free form keywords in the syntax tool limit keywords on only one, and soft limit to lables to only one

…s at the end

…e in dev mode

- types - match existing parse pattern - cleanup

Daniel Imms (Tyriar)

Part way through

Daniel Imms (Tyriar) · 2024-10-15T14:54:05Z

 		}

-		return folderRepoManager.activePullRequest;
+		return folderRepoManager.activePullRequest as unknown as T;


Is this a safe cast? Is a pull request model the same as an issue model?

A PullRequestModel extends IssueModel. I don't know why typescript doesn't the direct cast to IssueModel.

Daniel Imms (Tyriar) · 2024-10-15T14:55:00Z

+	comments?: IIssueComment[];
+	commentCount: number;


Is commentCount just comments.length? Seems redundant

They are not the same. commentCount will always be set, as in we will always fetch the number of comments using the GitHub API; however, for performance we do not always fetch any of the comments.

Daniel Imms (Tyriar) · 2024-10-15T15:01:12Z

+	dispose() {
+		dispose(this.disposables);
+	}


nit: Is there a base class to extends instead of this?

Nope, but we need one. Will tackle as debt across the codebase: #6285

Daniel Imms (Tyriar) · 2024-10-15T15:02:20Z

+	repo?: {
+		owner?: string;
+		name?: string;
+	};
+}
+
+interface ConvertToQuerySyntaxResult {
+	query: string;
+	repo?: {
+		owner?: string;
+		name?: string;
+	};


Is repo: {} valid?

No, but it is valid for SearchToolParameters as the llm might not give us the proper arguments. Having owner and name optional here was the best way I could see to do this later:

vscode-pull-request-github/src/lm/searchTools.ts

Lines 397 to 398 in fe22731

type SearchToolParameters = ConvertToQuerySyntaxResult;

which lets me describe that the output of one tool should be the input of the next.

Daniel Imms (Tyriar)

👏

Aiday Marlen Kyzy (aiday-mar) and others added 30 commits October 7, 2024 12:11

adding code

cb672bd

renaming ghpr to github

f367466

Add "issue" tool, still needs error handling

3bf14c2

renaming the particpant

3fe360a

wiring the tool and the chat participant

5b425be

Scaffold notifications view

04e3e28

Remove slash commands

83864f5

using single quotes instead

a8d05ef

cleaning up the code

69f325e

tweaking the prompt in order to prompt githubpr to use the workspace …

a4286d7

…tool to fix issues if so instructed

adding a command which sends a request to fix the issue given a githu…

fa3a421

…b url

removing the isSticky attribute in the package.json

be471a2

Resolve Issue/PullRequest

ef67df5

Use timestamp for cache invalidation

c5df5c9

Add commands in issues view

27dff2d

filing in the TODO, removing old command

43d2c26

Polish chat when clauses and menus

1d647bb

Add stub action to prioritize notifications

92c7389

Update participant name

5509cb3

Choose first repo if none provided in issue tool

c17ca7c

Basic priority computation. Lots of work left

105d678

Saving out changes

13ae00e

Increase notification page limit

cddee6c

add fix issue tool

143f59d

adding back semi-colon

d2cbc6e

renaming the types after the proposed API has been updated

89e83ff

processing notifications in batches

f52cb12

adding comments into the prompt for the notifications as well as reac…

cd9eca9

…tion, formatting the prompt

add labels to the prompt

e9bef81

adding the issue reactions into the prompt

d7f42cb

Aiday Marlen Kyzy (aiday-mar) and others added 16 commits October 14, 2024 11:52

add code to load more notification and hide load more notification …

4f06591

…when can not load more

Get "similar issues" search working

5adc593

add a prompt specifically for free form keywords in the syntax tool limit keywords on only one, and soft limit to lables to only one

add different sorting methods

68466fd

assigning sorting method

6c71d9a

adding utils file

8072ee0

small refactoring

9a0d33f

setting title if titleHTML is undefined

eb4c1ea

showing the notifications corresponding to closed issues or merged PR…

b1a9c32

…s at the end

add code

e547580

removing the sorting and adding a boolean which determines that we ar…

8a28e15

…e in dev mode

adding the reasoning of priority assignment

d709a4c

adding commands for notifications view

ea19ff0

only offer summarization option for issues

1ca98a2

using small letter for 'by'

ea0a632

using correct regex for priority reasoning extraction

9f7d0fa

Get @me working better and better handling of free form query

67a6a6a

Alex Ross (alexr00) self-assigned this Oct 15, 2024

💄

fe22731

- types - match existing parse pattern - cleanup

Alex Ross (alexr00) marked this pull request as ready for review October 15, 2024 10:22

vs-code-engineering Bot added this to the October 2024 milestone Oct 15, 2024

Alex Ross (alexr00) enabled auto-merge (squash) October 15, 2024 10:38

Alex Ross (alexr00) changed the title ~~Dev/chat~~ Add chat participant and tools Oct 15, 2024

Alex Ross (alexr00) changed the title ~~Add chat participant and tools~~ Add chat participant, tools, and notifications view Oct 15, 2024

Daniel Imms (Tyriar) reviewed Oct 15, 2024

View reviewed changes

Daniel Imms (Tyriar) approved these changes Oct 15, 2024

View reviewed changes

Comment thread src/lm/searchTools.ts

Comment thread src/lm/searchTools.ts

Comment thread src/lm/tools/issueTool.ts

Comment thread src/lm/tools/issueTool.ts

Comment thread src/notifications/notificationsView.ts

Alex Ross (alexr00) merged commit d5a6d39 into main Oct 15, 2024

Alex Ross (alexr00) deleted the dev/chat branch October 15, 2024 16:43

Alex Ross (alexr00) restored the dev/chat branch October 16, 2024 08:39

Alex Ross (alexr00) mentioned this pull request Oct 16, 2024

Add a disposable base class #6285

Closed

Alex Ross (alexr00) deleted the dev/chat branch October 16, 2024 10:38

Uh oh!

Conversation

Alex Ross (alexr00) commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daniel Imms (Tyriar) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Daniel Imms (Tyriar) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Alex Ross (alexr00) commented Oct 15, 2024 •

edited

Loading