[Nightly] Opening PR description page from tree not working when PR is not checked out - #2500
Merged
Merged
Conversation
…s not checked out Fixes #2499
Rachel Macfarlane (RMacfarlane)
requested review from
Alex Ross (alexr00) and
Eric Amodio (eamodio)
February 17, 2021 01:21
Alex Ross (alexr00)
approved these changes
Feb 17, 2021
| await this.updateState(); | ||
| await openDescription(this._context, this._telemetry, createdPR, this._folderRepoManager, this); | ||
| const treeNodes = await this.changesInPrDataProvider.getChildren(); | ||
| const descriptionNode = treeNodes[0] as DescriptionNode; |
Member
There was a problem hiding this comment.
To avoid relying on position 0 and casting, you could expose a getDescriptionNode on PullRequestChangesTreeDataProvider.
Contributor
Author
There was a problem hiding this comment.
Thanks, adding this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2499