Add experimentation service - #2488
Merged
Rachel Macfarlane (RMacfarlane) merged 2 commits intoFeb 12, 2021
Merged
Conversation
| const product = await getProductConfig(vscode.env.appRoot); | ||
| const targetPopulation = getTargetPopulation(product); | ||
|
|
||
| return getExperimentationService(`${pkg.publisher}.${pkg.name}`, pkg.version, targetPopulation, experimentationTelemetry, context.globalState); |
Contributor
Author
There was a problem hiding this comment.
I'm not sure what the consequence of the insiders and stable versions of the extension having different names here is, should they map to the same service?
There was a problem hiding this comment.
cool, we confirmed with Julie and Amy about showing this only in the stable version of the extension
Rachel Macfarlane (RMacfarlane)
requested review from
Alex Ross (alexr00),
Sana Ajani (sana-ajani) and
SteVen Batten (sbatten)
February 10, 2021 20:56
|
Looks good for the most part! Only other thing I think we need is to add the GDPR classification for the "query-expfeature" telemetry event (like we do in the remote-containers extension: https://github.com/microsoft/vscode-remote-containers/blob/9c5f61a5ff6c390e148c237ab6b0e110f204f015/src/utils/telemetry.ts#L9). |
Contributor
Author
|
Thanks! Added that classification |
Rachel Macfarlane (RMacfarlane)
deleted the
rmacfarlane/experimentationService
branch
February 12, 2021 23:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt the
vscode-tas-clientpackage for running experiments