Render resolved conversations differently on description page - #2471
Merged
Rachel Macfarlane (RMacfarlane) merged 1 commit intoFeb 8, 2021
Merged
Conversation
Rachel Macfarlane (RMacfarlane)
requested review from
Alex Ross (alexr00) and
Eric Amodio (eamodio)
February 5, 2021 23:39
| } | ||
|
|
||
| export function parseGraphQLComment(comment: GraphQL.ReviewComment): IComment { | ||
| export function parseGraphQLComment(comment: GraphQL.ReviewComment, isResolved: boolean): IComment { |
Member
There was a problem hiding this comment.
Why not update GraphQL.ReviewComment to include the resolved property so that you don't have to pass it as an additional param here?
Contributor
Author
There was a problem hiding this comment.
The property is actually at the thread level instead of on individual comments, but I thought adding a concept of threads instead of the comments we use everywhere was too big of a refactoring
Alex Ross (alexr00)
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch whether review threads are resolved, and show them collapsed on the description page.
First part of #339