Remove hard extensionDependency on auth extension - #2018
Merged
Rachel Macfarlane (RMacfarlane) merged 1 commit intoAug 3, 2020
Conversation
Alex Ross (alexr00)
approved these changes
Jul 24, 2020
Alex Ross (alexr00)
left a comment
Alex Ross (alexr00)
left a comment
Member
There was a problem hiding this comment.
What happens if the user disables the auth extension then?
Contributor
Author
|
If they disable it, they should see an error notification like "No provider with id 'github' registered". |
Rachel Macfarlane (RMacfarlane)
deleted the
rmacfarlane/extensionDependencies
branch
November 12, 2020 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kind of a weird change, the reasoning is that I need to move the GitHub Auth Provider extension to be a UI instead of Workspace extension. The auth provider API will make sure that regardless of what side the auth provider extension is on, calls to it go through. For Codespaces, the resolver extension is on the UI side, and it needs to get auth information at start up, before the Workspace extension host is even up. (Also, it makes sense for the auth provider to be on the local machine since that's where it's storing credentials).
Anyway, if GHPRI directly depends on it and is a workspace extension, it will fail to activate since the auth provider isn't on the same side. Since we don't actually need the extension to be in the same extension host, we shouldn't set it as a dependency