Upgrade to 18.0.1 octokit rest - #2017
Merged
Merged
Conversation
compareCommits doesn't work
Alex Ross (alexr00)
changed the title
Alex Ross (alexr00)
marked this pull request as ready for review
July 22, 2020 14:53
Member
Author
|
Everything that I tested is working, so I think that we're good to merge after review. |
Rachel Macfarlane (RMacfarlane)
approved these changes
Jul 22, 2020
Rachel Macfarlane (RMacfarlane)
left a comment
Rachel Macfarlane (RMacfarlane)
left a comment
Contributor
There was a problem hiding this comment.
This looks good overall!
| export interface AnnotatedOctokit extends Octokit { | ||
| currentUser?: Octokit.PullsGetResponseUser; | ||
| export interface AnnotatedOctokit { | ||
| octokit: Octokit; |
Contributor
There was a problem hiding this comment.
Instead of pulling this property in, what if we exposed currentUser on the GitHub interface below, making it a required property and setting it as part of createHub?
|
|
||
| private isWebviewReady = false; | ||
| protected async _postMessage(message: any) { | ||
| // Without the following ready check, we can end up in a state where the message handler in the webview |
Contributor
There was a problem hiding this comment.
Nice!
Member
Author
There was a problem hiding this comment.
Made it even better ( no setInterval).
Member
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2008