Skip to content

Fix icon fill color on light themes #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rachel Macfarlane (RMacfarlane) merged 1 commit into from
Jul 13, 2020
Merged

Fix icon fill color on light themes #1981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions preview-src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ body .comment-container .review-comment-header {
}

#status-checks svg {
fill: var(--vscode-foreground);
margin-right: 6px;
width: 16px;
}
Expand Down Expand Up @@ -359,8 +358,8 @@ body button.secondary:hover {
background-color: var(--vscode-button-secondaryHoverBackground);
}

body button svg {
fill: var(--vscode-button-foreground);
body button svg, body button svg path {
fill: var(--vscode-foreground);
}

body button .icon {
Expand All @@ -369,10 +368,6 @@ body button .icon {
margin-right: 6px;
}

body button.checkedOut svg {
fill: var(--vscode-foreground);
}

.prIcon {
display: flex;
border-radius: 10px;
Expand Down Expand Up @@ -468,7 +463,6 @@ body .overview-title .button-group button {
}

.section svg {
fill: var(--vscode-foreground);
width: 16px;
height: 16px;
display: block;
Expand All @@ -484,14 +478,6 @@ body .overview-title .button-group button {
flex-shrink: 0;
}

.vscode-dark .section svg path {
fill: #C5C5C5;
}

.vscode-light .section svg path {
fill: #424242;
}

.section-item {
margin-bottom: 8px;
display: flex;
Expand All @@ -517,7 +503,6 @@ body .overview-title .button-group button {
height: auto;
margin-right: 8px;
flex-shrink: 0;
fill: var(--vscode-foreground);
}

.comment-container.commit,
Expand Down Expand Up @@ -585,7 +570,6 @@ body .overview-title .button-group button {
height: auto;
margin-right: 8px;
flex-shrink: 0;
fill: var(--vscode-foreground);
}

.details {
Expand Down Expand Up @@ -848,14 +832,6 @@ code {
background-color: rgba(220, 220, 220, 0.4);
}

.vscode-light .comment-actions svg {
fill: #424242;
}

.vscode-dark .comment-actions svg {
fill: #C5C5C5;
}

.vscode-dark .comment-body pre:not(.hljs),
.vscode-dark .comment-body code > div {
background-color: rgba(10, 10, 10, 0.4);
Expand Down